File tree maxdepth #587
Open
File tree maxdepth #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
==========================================
+ Coverage 70.97% 71.76% +0.78%
==========================================
Files 161 175 +14
Lines 10776 12111 +1335
==========================================
+ Hits 7648 8691 +1043
- Misses 2949 3205 +256
- Partials 179 215 +36 ☔ View full report in Codecov by Sentry. |
hulto
reviewed
Feb 14, 2024
hulto
previously approved these changes
Feb 15, 2024
hulto
reviewed
Feb 21, 2024
| if isinstance(depth, str) and not depth.lstrip("-").isdigit(): | ||
| print("ERROR: Invalid depth specified, must be a valid number") | ||
| return | ||
| depth=int(depth) |
There was a problem hiding this comment.
This seem redundant with the above
There was a problem hiding this comment.
What do you mean redundant? -1 is not handled properly by the is digit function. This also gracefully exits rather than just crashing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind feature
What this PR does / why we need it:
Add permissions check to the file tree tome so it does not crash when encountering an unreadable directory